Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TCP CMU JS Updates #172

Merged
merged 2 commits into from
Jan 24, 2025
Merged

TCP CMU JS Updates #172

merged 2 commits into from
Jan 24, 2025

Conversation

ChrispinP
Copy link
Member

As part of the TCP CMU project and preparation thereof, these are the JS code changes:

Big Buttons
Submit Button
Breadcrumbs
Task Board Redirect
Auto-Submit Forms
Custom Nav Menu for both TCP & CSWZ

@ChrispinP
TCP CMU JS Updates
28e77c6 
TCP CMU JS Updates
@ChrispinP ChrispinP added enhancement Enhancement to an existing feature or app JavaScript Modified JavaScript code Knack Any Knack related PR's new feature Implementing a new feature labels Jan 15, 2025
@ChrispinP ChrispinP self-assigned this Jan 15, 2025
KaroEngstrom
KaroEngstrom approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@KaroEngstrom KaroEngstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for aligning the icons and updating button language where needed

chiaberry
chiaberry reviewed Jan 24, 2025
View reviewed changes
code/right-of-way/right-of-way.js
/*** Disable Breadcrumb Navigation Links for old TCP Application ***/
/***************************************************************/
/*******************************************************************/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨ so much prettier

chiaberry
chiaberry approved these changes Jan 24, 2025
View reviewed changes
Copy link
Member

@chiaberry chiaberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that you have some styles defined in the javascript as well as referencing css classes -- I did not dig in to see if any of the inline styles were overriding our custom css, but just want to put it out there for future style debugging.

@ChrispinP ChrispinP merged commit 956afd1 into master Jan 24, 2025
@ChrispinP ChrispinP deleted the ChrispinP-9819-js-tcpcmu branch January 24, 2025 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KaroEngstrom KaroEngstrom KaroEngstrom approved these changes

@susannegov susannegov susannegov approved these changes

@dianamartin dianamartin dianamartin approved these changes

@chiaberry chiaberry chiaberry approved these changes

@mddilley mddilley Awaiting requested review from mddilley

@TracyLinder TracyLinder Awaiting requested review from TracyLinder

Assignees

@ChrispinP ChrispinP

Labels
enhancement Enhancement to an existing feature or app JavaScript Modified JavaScript code Knack Any Knack related PR's new feature Implementing a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ChrispinP @chiaberry @dianamartin @susannegov @KaroEngstrom